Sean Lilley
Sean Lilley
Nope, looks good.
@Tamrat-B thanks for the update and detailed summary. I'm planning on reviewing in the next week or so.
This looks great @DanielLeone! And a long time in the making too. We occasionally get high res terrain that suffers from horrible picking performance so I'm glad to see support...
A few more I can think of right now * [x] Allow dynamic model matrix updates to scene graph. This can be done before animations proper. * [x] Support `AGI_articulations`...
In addition to basic 2D/Columbus View support... * [x] Viewing models and tileset correctly in 2D: https://github.com/CesiumGS/cesium/issues/5112
Haha, I remember the `WalkingLady` model being one of the more problematic ones when adding support for glTF 2.0. 😄
@engine5d thanks for the bug report. This is a CesiumJS limitation, not a 3D Tiles spec limitation. @ptrgags you might be able to provide more details here. I remember this...
@sanjeetsuhag is the new atmosphere still evaluated per-vertex by default?
I started to address that here: https://github.com/CesiumGS/cesium/tree/skip-lods-experimental The `ModelExperimentalDrawCommand` refactor was pretty far along and I was about to change how commands are pushed to the command lists to avoid...
> should the `noData` value be passed in to the shader and the user is responsible for interpreting it? Yeah I think that's a good path to start