Sean Lilley
Sean Lilley
@ptrgags could you post a new summary of the changes required here? Some things have changed in the spec and implementation since - notably `defaultValue` was added back to the...
> not sure if ternary operators lead to divergence Might depend on the compiler and complexity of the expressions. `czm_branchFreeTernary` could be used instead.
Hm this brings up bigger questions about the custom shaders API. We also need to consider min, max, and statistics. What about sub-structs for these special properties? Only problem is...
It seems like this issue could be split into two PRs: * Add `noData`, `default`, `min`, `max`, `statistics` to the custom shader API * Handle `noData` and `default` internally when...
> Note that statistics only exist in `3DTILES_metadata` (the 3D Tiles extension), not the glTF extension. You can access it through tileset.metadataExtension.statistics, that just gives you an object that matches...
> we need to load a 3DTileset in MetadataPipelineStageSpec to test statistics. Can we mock the tileset like in [`PickingPipelineStageSpec`](https://github.com/CesiumGS/cesium/blob/a8c27a25fc4d810788a8c30f3e8ea8ba0b773fc7/Specs/Scene/ModelExperimental/PickingPipelineStageSpec.js#L130-L134)? Generally I'm not a fan of mocking objects but it...
> Use the `MetadataStatistics` property name to look up the type used by the corresponding `PropertyTextureProperty` or `PropertyAttributeProperty` This option seems cleaner to me. It can leverage some of the...
Related issue: https://github.com/CesiumGS/cesium/issues/10465
> @lilleyse believes this might be because the quantization is hardcoded in a few places in our Draco decoding. Specifically I wouldn't be surprised if UNSIGNED_SHORT is hardcoded somewhere.
This also came up in https://github.com/AnalyticalGraphicsInc/gltf-pipeline/issues/511