Colin Seymour

Results 448 comments of Colin Seymour

The PR is good to go but I can't merge it whilst it still has the unneeded `vendor/grammars/SublimeGodot` submodule.

> I'm not sure where to place a `deno.lock` for tests. I `grep`ed around, but I couldn't find a `Dummy/` folder. We already have one: https://github.com/github-linguist/linguist/blob/master/samples/JSON/filenames/deno.lock https://github.com/github-linguist/linguist/pull/6783 is a recent...

> Would you say that if we include 1.0, 1.2 and 1.4 and add also add another language with a `.dml` extension, there is a chance that support for the...

> @tonyfettes Should `.mbti` extension be added also? I've advise against it as usage is not sufficient for inclusion right now so adding it to this PR will delay this...

> The extension of the new language is used in hundreds of repositories on GitHub.com. https://github.com/search?q=path%3A*.aleo+aleo+NOT+owner%3AProvableHQ++NOT+owner%3AAleoNet+NOT+is%3Afork&type=code. Note that a file is expected to occur once per repository, which meets the...

> It has enough popularity (in and out of github) It definitely doesn't. It is miles away from our [requirements](https://github.com/github-linguist/linguist/issues/5756).

Public popularity on GitHub is the only measure we use (we don't have exposure to private repo code so can analyse this) and third-party stats and things like download stats...

> Also, any idea on the test failuers? Yup. Looks like the LiveScript grammar has been removed: ``` Error updating vendor/grammars/LiveScript.tmbundle Cloning into '/home/runner/work/linguist/linguist/vendor/grammars/LiveScript.tmbundle'... fatal: could not read Username for...

> @lildude can’t help with that But you owned the repo until very recently. Do you have an another source for the language's grammar? If not we'll have to remove...

> I don’t think anyone cares about livescript these days. @paulmillr That may be the case, but there is still code on GitHub and people will notice and complain. Your...