linguist icon indicating copy to clipboard operation
linguist copied to clipboard

Add GDShader

Open FireCatMagic opened this issue 1 year ago • 1 comments
trafficstars

Description

Adds support for GDShader / Godot Shading Language. Will close the issue I made for it: https://github.com/github-linguist/linguist/issues/7067 GDShader is the shading language used for Godot Engine https://godotengine.org/ It is very similar to GLSL https://docs.godotengine.org/en/stable/tutorials/shaders/shader_reference/shading_language.html

This language has been known by the community as both GDShader and Godot Shading Language, as it lacked a true name. This problem was solved and it is officially being known as GDShader. (see https://github.com/godotengine/godot-proposals/issues/10784)

Checklist:

  • [x] I am adding a new language.
    • [x] The new extension is used in hundreds of repositories on GitHub.com
      • Search results for each extension:
        • https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.gdshader+shader_type
        • https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.gdshaderinc
    • [x] I have included a real-world usage sample for all extensions added in this PR:
      • Sample source(s):
        • https://github.com/gdquest-demos/godot-shaders/blob/main/godot/Shaders/dissolve.gdshader
        • https://docs.godotengine.org/en/stable/tutorials/shaders/your_first_shader/your_first_3d_shader.html
        • https://github.com/gdquest-demos/godot-shaders/blob/main/godot/Shaders/gaussian_blur.gdshader
        • https://docs.godotengine.org/en/stable/tutorials/shaders/shader_reference/shader_preprocessor.html
        • https://godotshaders.com/shader/stylized-grass-with-wind-and-deformation/
        • https://godotshaders.com/shader/wind-waker-water-no-textures-needed/
      • Sample license(s): In same order of sources:
        • MIT
        • MIT
        • MIT
        • MIT
        • MIT
        • CC0
    • [x] I have included a syntax highlighting grammar: [URL to grammar repo] https://github.com/GodOfAvacyn/gdshader-lsp.git
    • [x] I have added a color
      • Hex value: #478CBF
      • Rationale: The color used for Godot's other language, GDScript, is #355570, so I didn't want to use an exact same color. I was thinking from the start to differentiate them I would still use a shade of Godot blue, but lighter. So I went and color-picked the Godot Engine logo and it was the perfect color - still a Godot color but enough to differentiate from GDScript files.
    • [ ] I have updated the heuristics to distinguish my language from others using the same extension.

FireCatMagic avatar Oct 01 '24 23:10 FireCatMagic

Ok, I removed gdshader-lsp

https://github.com/godotengine/godot-vscode-plugin Also supports GDShader (and GDScript) and has the MIT license - but it seems like this grammar is already included in the project, so I can't add it

FireCatMagic avatar Oct 04 '24 18:10 FireCatMagic

The PR is good to go but I can't merge it whilst it still has the unneeded vendor/grammars/SublimeGodot submodule.

lildude avatar Jun 02 '25 09:06 lildude

The PR is good to go but I can't merge it whilst it still has the unneeded vendor/grammars/SublimeGodot submodule.

Forgot all about this, I'll get to that now

FireCatMagic avatar Jun 02 '25 15:06 FireCatMagic