Colin Seymour

Results 448 comments of Colin Seymour

> Please unsub me from this convo. @paulmillr Only you can do that… using the button specifically for it in the sidebar > New grammar repo: [http://github.com/sharktide/livescript-vscode.git](https://github.com/sharktide/livescript-vscode.git) > > @lildude...

https://github.com/tientq64/livescript-vscode might do the trick. > I can maintain it; I am familiar with JavaScript and TypeScript, and livescript is also up my alley. Do you which files to delete...

> Its been a month. Can you _please_ review? Pending popularity PRs are reviewed each time a new release is made. > A .repy file is typically used only once...

> Understood. We wait. But technically this should have been reviewed after v9.2.0 It was. I don't comment on every PR each time I check availability.

> @lildude ok, but can you tell me why? Sure... it's what you want πŸ˜‰ ![Screenshot 2024-10-14 at 17 52 58](https://github.com/user-attachments/assets/ca0e86e8-28c4-4131-8d03-84ea8b68c5d1) As you're adding the extension to the XML language...

You need to add this to the list of no-root-tag entries in the test too: https://github.com/github-linguist/linguist/blob/f164d13fa618023ecf2d8f2ed9a6ce5fae731346/test/test_strategies.rb#L176-L194 This will exclude the sample from the XML strategy testing which is what is...

> Hello @lildude just wondering if you and your team had had the chance of taking a look into this. No. I only review pending popularity PRs when I make...

> Perhaps you could reconsider the "pending popularity" status? What do you think? :) No. This would set a precident that defeats the point of having [usage requirements](https://github.com/github-linguist/linguist/issues/5756) which I'd...

> (I assume this would be as simple as adding node, and I guess nodejs, to the list of typescript interpreters in languages.yml? Yup, however this is already the case...

> I can't imagine that there are going to be extensionless files that are actually typescript (node wouldn't process them as such) πŸ€” If there are never going to be...