Daniel Goldman
Daniel Goldman
Thanks for explaining, I'll keep that in mind as I'm developing. I've got an MR up that will `validate` modules again, adds the `skip_terraform_validate` flag, and also adds some documentation....
Sorry, I missed the last query there. I don't think Pants currently has a way to set the deployment order of deployable targets. I think using the `dependencies` field here...
Thoughts on whether the per-target option should shadow or add to the global option?
This is mostly fixed by the sort, but there are some remaining. All the remaining diffs look to be in "name_to_api_type_info" with types that are provided in multiple places. I...
I categorised this one as an internal change because you could already generate lockfiles for these tools (unlike Python, where you couldn't).
I called it out, it can't hurt and if we did cause problems then someone debugging can get a hint.
I think we're good to go. I thought that it might be nice to have a toggle to turn this off, in case it causes problems during migration or people...
> Is that on your radar? It probably should have been, the purpose of this MR was to remove those 😅. Thanks for pointing them out, I've updated them >...
what's the "source" of module "dashboard_cert"? Any chance it's a transitively-included module?
Oh, seems we're swallowing errors during init: ``` ╷ │ Error: Failed to download module │ │ Could not download module "dashboard_cert" (../mod1/main.tf:8) source code │ from │ "git::https://github.com/terraform-aws-modules/terraform-aws-acm?ref=v4.5.0": │...