pants icon indicating copy to clipboard operation
pants copied to clipboard

Mark all Python tools as exportable

Open lilatomic opened this issue 10 months ago • 2 comments

Following to #20730 , this MR flags all Python tools as exportable. It omits some internal tools (for example, parsers for dependency inference).

I think there's a risk that someone tries to export a Python-based tool without activating the Python backend. I also want to look into a few instances where some lockfile rules are registered and see if those registrations are still necessary.

lilatomic avatar Apr 13 '24 21:04 lilatomic

When you have a chance, please merge main (or rebase onto it) and add some release notes to docs/notes/2.22.x.md. See https://github.com/pantsbuild/pants/discussions/20888 for more info.

Also, other than that, is this waiting on anything other than hitting the merge button?

huonw avatar May 08 '24 05:05 huonw

I think we're good to go. I thought that it might be nice to have a toggle to turn this off, in case it causes problems during migration or people don't like the UX of having all resolves suggested together. I'm not sure that's worth the effort, though

lilatomic avatar May 18 '24 17:05 lilatomic

Is that on your radar?

It probably should have been, the purpose of this MR was to remove those 😅. Thanks for pointing them out, I've updated them

I thought that it might be nice to have a toggle to turn this off, in case it causes problems during migration or people don't like the UX of having all resolves suggested together. I'm not sure that's worth the effort, though

We can see how it goes in dev release testing and retro-fit if required, I imagine?

Makes sense

lilatomic avatar May 22 '24 16:05 lilatomic