Daniel Goldman

Results 95 comments of Daniel Goldman

> Okay, so - in the process of reviewing. Is there a mechanism to NOT take and entire subfolder and have it owned by Ansible? Like, can the list of...

Someone who knows something about Rust dev and the REAPI should probably weigh in instead of me, but it looks good. Do we know if there's a test that covers...

> That's still a decent improvement, but clearly could be a lot more. There is something to also be said about creating sandboxes and whatnot for lint/check-based operations that won't...

confirming reproduction. Digging into it, we process all items in `.pants.rc` twice. Need to do more digging to find out why. (with `replace` actions (everything except for add or remove)...

In [OptionParser.new](https://github.com/pantsbuild/pants/blob/dc0aa0a6444618435c60f8807ab89997885f5910/src/rust/engine/options/src/lib.rs#L276) we skip config discovery if we've been passed some discovered configs https://github.com/pantsbuild/pants/blob/dc0aa0a6444618435c60f8807ab89997885f5910/src/rust/engine/options/src/lib.rs#L326-L328 But we don't skip reading from the `.pants.rc` file https://github.com/pantsbuild/pants/blob/dc0aa0a6444618435c60f8807ab89997885f5910/src/rust/engine/options/src/lib.rs#L382 When starting up initially, we don't...

Ah, seems passing in the configs is necessary for integration tests. They do some stuff to set the OptionsBootstrapper. That makes sense. I think then that the solution is to...

ah, so one wrinkle is that the image refs include values that are passed in as vars _and_ values that are there by default/in the chart. So if you're deploying...

> I wonder though why we need the wildcard `*` in `external_docker_images` as that gives two different ways of silencing errors/warnings about unknown docker image references. There's a bit of...

I think that if we shipped both lockfiles, we could make rolling back be as simple as creating a resolve that points to the lockfile using the internal syntax (`resource://`),...

Seems that the sha256sum bins are different. We expect it to have a `--status` option, but the one from alpine (upstream is busybox) uses `-s` for that.