Lion

Results 112 comments of Lion

Нельзя системную динамически подключать, они разные на разных дистрах и можно краш спокойно поймать. Надо именно что латать статическую сборку libcurl, и хорошо бы в апстрим. Это же логично: собираеш...

Ну так о том и речь, в статической надо перебирать все те адреса не в конфигуре, а в коде. Так оно на любой системе будет рассчитано на то-же, на что...

I face this issue while compiling ffmpeg qsv module: ``` qsv.c Assertion failed: cache2.n[0] == 2, file convert.c, line 546 ``` I can workaround this by replacing MFX_MAKEFOURCC define with...

There is license in read-me at the end: >Copying >------- > >All of the source code and documentation for gifenc is released into the >public domain and provided without warranty...

@audioboy77 @hajimehoshi Looks like this code have multiple bugs and needs testing. I've prepared some test vectors to cover all cases: https://github.com/lieff/minimp3/tree/master/vectors FFmpeg fate test vectors definitely not enough.

>next_frame seems to always return Some. So this is a minimp3 bug, not ours. I have little experience in rust. Can you debug why ``` pub fn next_frame(&mut self) ->...

Yes, I try to understand how it can happen. If Ok(frame) always returned ``` if samples == 0 { if frame_info.frame_bytes > 0 { Err(Error::SkippedData) } else { Err(Error::InsufficientData) }...

>But there is no reason to call decode_frame when bytes_read is Some(0). ``` async fn refill_future(&mut self) -> Result { use tokio::io::AsyncReadExt; let mut dat: [u8; MAX_SAMPLES_PER_FRAME * 5] =...

Not minimp3-rs bug then, can't reproduce issue with bundled mp3 test file and decoder.next_frame() successfully returns Err(Error::Eof) on eof.