Lion

Results 112 comments of Lion

Currently no plans about encoder, but I can reconsider if it's needed =)

@LaurentGomila It's fully feature complete. I'm still working on test procedure checking, check more compilers and further optimization. I will look at encoder later, I think it's not so hard...

I found BSD 2-Clause mp3 encoder from Andreas Johansson. Is it good enough license?

Well then, I've created repo with it https://github.com/lieff/mp3-enc-bsd Now we have both, decoder and encoder.

Encoder testing is more complicated than decoder (because we have no precise reference to compare with). I've tested it briefly and found over-read problem ([mp3 @ 0x7fc72c002700] overread, skip -4...

About encoder - I think It's from old freebsd/linux. Mentions can be found on old sites http://linux-sound.org/mpeg.html http://sunsite.univie.ac.at/Linux-soundapp/mpeg.html but archive is hard to find.

SoundFileReader should be easy. Is it's ok without SoundFileWriter, I can give it a try. For writer here another option https://github.com/cpuimage/tinymp3 No mention of license though, but it should be...

@mirh Yes, I tried -mfpu=neon: ``` CC=arm-linux-gnueabi-gcc CFLAGS="-O2 -mcpu=cortex-a15 -mfpu=neon -mfloat-abi=softfp" ../configure --host=arm-linux-gnueabi --disable-shared ``` Android NDK works fine with -mfloat-abi=softfp and -mfpu=neon, but with regular gcc seems slow runtime...

At time of testing both gcc and clang was available in Android NDK. And both was fine. Yes this runtime functions looks like software-only emulation https://gcc.gnu.org/onlinedocs/gccint/Soft-float-library-routines.html without any fallback https://github.com/lattera/glibc/blob/master/soft-fp/addsf3.c...

Re-tested with ``CC=arm-linux-gnueabi-gcc CFLAGS="-O3 -mcpu=cortex-a15 -mfpu=neon -mfloat-abi=softfp -ffast-math" ../configure --host=arm-linux-gnueabi --disable-shared --enable-float-approx``, gcc-9 and latest git: ``` Total executed instructions: 16372422266 silk_NSQ_del_dec_c 4974089295 30.381% silk_warped_autocorrelation_FLP 1405601164 8.585% __aeabi_fadd 956778274 5.844%...