Liam Han

Results 16 comments of Liam Han

Added 3 more tests for the triggered_publisher.cc. - Test for service that's unavailable -> timeout - Test for one input and one service - Test for one input and multiple...

@mabelzhang Thank you so much for the thorough review! And sorry about all the silly syntax/grammar mistakes haha But please keep providing me all these feedback so that I can...

@mabelzhang, @clalancette and I chatted on Thursday and decided to just make this much simpler by using the blocking `Request` method instead of non-blocking `Request` method. I just pushed everything...

hmm I'm not getting any error locally on my side. I ran at least 30 times with no error. I also tried testing it with 100 and 500 publications instead...

update: It was caused by callback method looping faster than the DoWork method. Hence, the triggerSrv variable could've been set twice in the callback while only invoked once in the...

I removed the `rep` but is there a way to check the gcc warnings locally before pushing? Also, I'm not sure how to navigate to `GitHub check ignition_gazebo-ci-pr_any-ubuntu_auto-amd64`. https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-ubuntu_auto-amd64/9628/

Brilliant! Thanks for all the thorough review Mabel!

So I was able to resolve this issue by just running the command on the IDE. I have vscode.

happy to help. Let's keep the chat on here so others can also take a look if they have similar issues. Below are the code that I'm running on vscode....