obsidian-creases icon indicating copy to clipboard operation
obsidian-creases copied to clipboard

Published 20 hours ago • verified publisher icon liamcain

bug breaking block reference

Open nicolasmarc1 opened this issue 2 years ago • 7 comments

Hi,

adding creases on sections that end with a block-id reference should add creases before (and not after) the block id, otherwise the block-id won't work anymore and the block reference break.

Thanks!

nicolasmarc1 avatar Mar 28 '22 16:03 nicolasmarc1

Good catch, I hadn't considered that. Will make a fix!

liamcain avatar Mar 29 '22 00:03 liamcain

This should be fixed in v0.6.4

liamcain avatar Apr 16 '22 18:04 liamcain

Hi! So i tried with the last version 0.6.4, but the problem seems to be the same, it add creases after the block id, is this working for you? Thanks!

nicolasmarc1 avatar May 15 '22 18:05 nicolasmarc1

Strange, this is the behavior I'm seeing:

https://user-images.githubusercontent.com/693981/168488113-77303a0e-6f60-42ed-9aa0-d3cbd7f222a0.mov

If there's additional steps for how to reproduce the issue, let me know!

liamcain avatar May 15 '22 18:05 liamcain

Strange, this is the behavior I'm seeing:

Screen.Recording.2022-05-15.at.2.25.12.PM.mov If there's additional steps for how to reproduce the issue, let me know!

Hi, thanks for the quick reply! This is weird, but doing the same things with the last version doesn't seem to work for me (windows 11) , not sure why. Here's the video demo:

https://user-images.githubusercontent.com/51007222/168869878-52cf4c5b-75b4-41a2-a5bc-974e7131c039.mp4

nicolasmarc1 avatar May 17 '22 17:05 nicolasmarc1

Thanks for the screen recording! I reopened the issue and will take another look, it might have something to do with the different commands (toggle crease vs crease current folds)

liamcain avatar May 17 '22 19:05 liamcain

Yes i think you are right as "Toggle Crease" works for me! I mostly use 'crease current folds" to match with all obsidian folds

nicolasmarc1 avatar May 20 '22 08:05 nicolasmarc1

I can confirm, the issue is in fact with crease current folds. toggle creases works perfectly. hopefully that should make it a relatively simple fix, if its easy to just use the logic from toggle creases.

if I have time ill take a look myself although id put it at a 20% that I end up fixing it - I have no experience developing obsidian plugins and if it takes too long to get it set up and working locally, and then to figure out the structure of plugins in general ill have to stop.

danrthompson avatar Sep 23 '22 19:09 danrthompson

I can confirm, the issue is in fact with crease current folds. toggle creases works perfectly. hopefully that should make it a relatively simple fix, if its easy to just use the logic from toggle creases.

if I have time ill take a look myself although id put it at a 20% that I end up fixing it - I have no experience developing obsidian plugins and if it takes too long to get it set up and working locally, and then to figure out the structure of plugins in general ill have to stop.

Hi, i already made a pull request today with a fix, hopefully it gets accepted soon

nicolasmarc1 avatar Sep 23 '22 19:09 nicolasmarc1

OK great! Thanks very much for letting me know before I jumped in!

danrthompson avatar Sep 23 '22 20:09 danrthompson

Hello @liamcain, any plans for a release with that fix ? thanks!

nicolasmarc1 avatar Oct 19 '22 16:10 nicolasmarc1

Hello @liamcain, any plans for a release with that fix ? thanks!

nicolasmarc1 avatar Dec 28 '22 20:12 nicolasmarc1

Thanks for bumping this @nicolasmarc1. Sorry for the long wait. I just released v0.6.6 with the fix.

liamcain avatar Dec 29 '22 16:12 liamcain