Chen Liang

Results 625 comments of Chen Liang

> > I recommend making the container getter method in `AttachmentTarget` abstract and having another `InternalAttachmnetTarget extends AttachmentTarget` in impl package that defaults the method instead. The `InternalAttachmnetTarget` will be...

> We'd have to pass `AttachmentTarget` directly though, and the supplier would have to do an instanceof check? I believe passing `AttachmentTarget` directly suffices, as they have a lot of...

> It's not in the impl package? AttachmentTarget is injected and it's part of the api package. No, I mean something like this: ```java package net.fabricmc.fabric.api.attachment.v1; // ... public interface...

> still not fan of exposing this Fabric API implementations have tons of internal accessor mixins in impl packages, and you don't fear exposing those though mods can call it...

> > Fabric API implementations have tons of internal accessor mixins in impl packages, and you don't fear exposing those though mods can call it freely. Curious. > > I...

So about the pr itself, this seems to add two things: 1. Loading of en_us language content from mods on dedicated server 2. Loading of other language contents on dedicated...

I agree with putting the language switch api for mods on hold; if we do add that, the resource loader would be a good home to it, as the resource...

@sfPlayer1 Can you approve running workflows (right above the comment box) so ci can check for checkstyle violations etc?

I agree this current strategy is enough, given this strategy is quite deterministic. Since you say conflicts are rare, I wish you can just put the logging process into the...

Requesting another look. The main advantage of this is that without server languages, console-typed commands will print translation keys for their localized text feedbacks.