Lari Hotari

Results 996 comments of Lari Hotari

> With the current implementation, the only way to nack for some business reason is to throw a RuntimeException and the retry is managed by reactor (see [pipelineRetrySpec](https://github.com/vroyer/pulsar-client-reactive/blob/main/pulsar-client-reactive-api/src/main/java/org/apache/pulsar/reactive/client/internal/api/DefaultReactiveMessagePipelineBuilder.java#L66)). In this...

> I just wonder why you don't have the same approche for both the consumer and the pipeline. The consumer returns a MessageResult to ack/nack, while the pipeline signal an...

> Ok, you can just pick up the first commit for the DeliveryBackoff and fix the pipeline to nack without making a retry unless there is a PulsarClientException. That will...

Thanks for the contribution @alesharik. Would it be possible to add some tests to validate the added feature? I'm not familiar to this code base and how it's tested.

@freeznet @mattisonchao Please review this PR.

> Hi, @lhotari I think yes. I'll look into that tomorrow @alesharik Thanks! There doesn't seem to be very many tests in the project currently. Improving on that in this...

> @lhotari do you by chance have any time ? @lburgazzoli I'd like to help, but unfortunately my time is very limited at the moment. I'm currently working 100%+ on...

I have reported the Netty 4.1.111.Final compatibility issue as grpc/grpc-java#11284 . There's a repro case using jetcd-core/jetcd-test 0.8.2, vert-grpc 4.5.8, grpc-java 1.64.0. It is described in the issue comment https://github.com/grpc/grpc-java/issues/11284#issuecomment-2168113850.

> @lhotari do you have an example about how you configure ssl ? @lburgazzoli This is the example from Apache Pulsar: https://github.com/apache/pulsar/blob/f3d4d5ac0442eed2b538b8587186cdc0b8df9987/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/EtcdMetadataStore.java#L138-L148 . (The Pulsar code is now using [the...

> but provided as an interface with an internal implementation to hide netty(grpc classes and to make the current setup deprecated for 1 release, > > @lhotari would that work...