Lari Hotari

Results 996 comments of Lari Hotari

Having gzip support for all http endpoints could be useful too. I wonder if it could be simply enabled for all by default. @codelipenghui wdyt?

> @lhotari Done. I suggested several changes. @asafm great work on the review! Thanks

> Can we enable conditional compression that only compresses payloads above a certain size? Yes, that is supported in GzipHandler. https://www.eclipse.org/jetty/javadoc/jetty-9/org/eclipse/jetty/server/handler/gzip/GzipHandler.html#setMinGzipSize(int)

Related explanation about ZkBookieRackAffinityMapping: https://github.com/apache/pulsar/issues/151#issuecomment-268802489 . On the broker side, ZkBookieRackAffinityMapping will get used for the bookie client when `bookkeeperClientRackawarePolicyEnabled=true` in `broker.conf`.

@tisonkun Have you checked with a debugger or logging that the tests actually do what they are claiming to do? (for example recover after OOME) I'm not a great fan...

@eolivelli Would it be possible to cherry-pick #9232 to branch-2.7 so that it would be possible to configure `waitTimeoutOnBackpressureMs` on the broker side by using `bookkeeper_waitTimeoutOnBackpressureMs` configuration key?

There is also https://github.com/apache/bookkeeper/issues/2521 in BK related to the lack of backpressure configuration in Pulsar by default.