pulsar-rs icon indicating copy to clipboard operation
pulsar-rs copied to clipboard

Add support for client auth using TLS

Open alesharik opened this issue 1 year ago • 6 comments

Closes #197 Fork of PR #267 , and it's rebase attempt, because seems like original PR is unmaintained

alesharik avatar Sep 18 '24 06:09 alesharik

@lhotari can we get assistance in getting this PR merged?

lightistor avatar Feb 19 '25 00:02 lightistor

Thanks for the contribution @alesharik. Would it be possible to add some tests to validate the added feature? I'm not familiar to this code base and how it's tested.

lhotari avatar Feb 19 '25 10:02 lhotari

@freeznet @mattisonchao Please review this PR.

lhotari avatar Feb 19 '25 10:02 lhotari

Hi, @lhotari I think yes. I'll look into that tomorrow

alesharik avatar Feb 19 '25 16:02 alesharik

Hi, @lhotari I think yes. I'll look into that tomorrow

@alesharik Thanks! There doesn't seem to be very many tests in the project currently. Improving on that in this area could require more effort than usual because of the lack of examples of how things are handled in pulsar-rs.

lhotari avatar Feb 21 '25 06:02 lhotari

@lhotari hi! I added copy of roundtrip test which connects over TLS. Also added all necessary certs (in .github/certs), script to generate them and modified CI to run Pulsar in TLS+plain mode. It works on local machine when running Pulsar 3.1.3 with command provided in CI; but I am not sure if it will run in Github Actions

alesharik avatar Mar 01 '25 18:03 alesharik