Lehman Garrison
Lehman Garrison
Yes, because any time we add a duplicate cell pair, it is with a different offset (`xwrap` value).
Oh, I definitely agree that if you add a truly identical cell pair—same `icell` & `icell2`, and same `xwrap`—you get duplicate particle counts! My point is just that `generate_cell_pairs` does...
Hey @manodeep, have you had a chance to look at the new approach to this problem?
> Thanks for your patience @lgarrison - on parental leave at the moment, so time is extremely limited. Oh, no worries! There's no rush. > I took another look at...
> @lgarrison Think I have finally understood where the update is relevant - the check for duplicate cells was throwing me off. If I understand correctly, the fix is relevant...
> Now that I (mostly) understand what's going on, the changes seems good. Perhaps, add one more test with ~100 particle positions, say 50 each around [$0 \pm \delta$, $Lbox/2...
Great, thanks! I'll revisit #276 next, once I remind myself what I was doing there 😅
@manodeep I'll leave this to you as I'm pretty useless at Mac! @ziarriall I've lightly edited your comment for formatting
I think it would be good to provide an option to have the last bin boundary closed. Actually, I think it makes sense to have it be the default behavior,...
I think I'd agree with including separations in r that match the end of the last bin in general (someday!). And to be clear, that's what I was proposing the...