Lehman Garrison
Lehman Garrison
Great! @manodeep do you want to check my last two commits?
Thanks @manodeep, I've added the warning and the parentheses as you suggested. I'm not sure I follow the suggestion about the inverse xdiff. Wouldn't using the boxsize when xdiff is...
That makes sense, I think such a feature would be useful. You're right that the internal mechanisms are there, it's just a matter of plumbing the functionality to take a...
Yes, I think you're right! Everything should be computed using the weights. Would you like to open a PR?
@manodeep, thanks, I had forgotten our discussion! It's coming back to me now. However, since adding the weights over 5 years ago (!), I think I've changed my mind on...
Yeah, we already have an `output_ravg` field that we normally set to `True`, but we could allow the user to set that to the string `'weighted'` instead. Then the average...
Just confirming that I can run your script and get the same output; thanks for making the minimal reproducer! Haven't had a chance to track down the bug yet. On...
@manodeep is it possible that we we are missing particles when we do duplicate cell elimination because we are only considering one "wrapping" direction? I think we need to consider...
@manodeep Yes, I think since we happen to be making a release right now anyways we should revert this change while we consider the best way to fix this. Let's...
I've never looked at that part of the code very carefully! On the surface, they sound like useful code options; are they deprecated/not useful in some way?