Lehman Garrison
Lehman Garrison
I think this should be a fairly straightforward change, especially since nearly all the parts of the code that need to change can be found just by searching the codebase...
I think we boost along two axes in most cases to help with this, e.g. https://github.com/manodeep/Corrfunc/blob/master/theory/DD/countpairs_impl.c.src#L252-L255 But I agree, we should just compute a target density and set the bin...
Thanks! I think this is consistent with what we're doing in `Corrfunc.theory.xi()`, so I agree with this change. Would you mind checking that `Corrfunc.theory.xi()` and `convert_3d_counts_to_cf()` now agree?
No, you're absolutely right! I was mis-remembering that we also supported the natural estimator in `convert_3d_counts_to_cf()`. Is there another consistency check we could do? Such as, supply analytic DR and...
It's definitely relevant, as it was designed to show that `(ND-1)/V` is the right density to use for the randoms in the natural estimator: https://gist.github.com/lgarrison/1efabe4430429996733a9d29397423d2 That's why I was thinking...
The in-place version will need to use swaps instead of argsort. Or we'll need to figure out how to do an efficient in-place permutation. Either way, it should be parallelized.
I followed @rainwoodman's example and tested this on an AVX2 machine, and it doesn't seem to trigger the "Illegal Instruction" error. I do get a different error partway through the...
`mpi4py` sounds like a good way to go. What are you imagining as the input file organization? If the points are all in one file, does the master process decide...
I agree that's worth looking into. It would be nice if all ASDF compression passed through this library instead of each individual compression library. Even nicer would be if Numcodecs...
Digging into the Numcodecs source a bit more, I think perhaps the reason I couldn't find anything about the binary header format is that there isn't one! The user is...