Laurence de Bruxelles
Laurence de Bruxelles
At a high level there are two options: - A: Run the v12 docs and v13 docs apps with different code - B: Run the v12 docs and v13 docs...
> @lfdebrux thanks! I think you covered most of it > > > We can have more flexibility with how we present different versions of docs and move from one...
@ruthhammond has decided we should go with option B, although keeping the option to split out the v12 docs in future, and keeping the v12 docs in a separate folder...
Followup ticket: https://github.com/alphagov/govuk-prototype-kit-docs/issues/59
As part of this work we should consider making it so that we can enable `useAuth` in tests without also needing to set `NODE_ENV=production`. Ideally we should be able to...
I thought it would just be a case of running `npm shrinkwrap`, but of course, with Node.js it's never that simple 🤦 It turns out with older versions of npm...
I'm putting this in blocked until we've made a decision on what versions of Node we support (#1124).
The reason this is happening is because we've folded `application.css` into the extensions system [[1](https://github.com/alphagov/govuk-prototype-kit/blob/bf4474e0b05957465c91b87d76e055250c0fd06c/server.js#L56)]; the default page `head` does not include `application.css` directly [[2](https://github.com/alphagov/govuk-prototype-kit/blob/bf4474e0b05957465c91b87d76e055250c0fd06c/lib/nunjucks/govuk-prototype-kit/layouts/govuk-branded.html#L5-L7), [3](https://github.com/alphagov/govuk-prototype-kit/blob/bf4474e0b05957465c91b87d76e055250c0fd06c/lib/nunjucks/govuk-prototype-kit/includes/stylesheets.html)]. Undoing this specific change...
We've agreed to back out the changes adding `application.css` to the extensions system to fix this for now, I'll raise a PR for that now. But we'd like to revisit...
Something to be added to the pile is documentation for developers of plugins, as @nataliecarey mentioned in dev catch-up today that will be important as things users used to be...