govuk-prototype-kit icon indicating copy to clipboard operation
govuk-prototype-kit copied to clipboard

Fix unbranded template to use the right font

Open joelanman opened this issue 3 years ago • 1 comments

What

Unbranded template is currently using Transport, it should be using this font stack:

"HelveticaNeue", "Helvetica Neue", "Arial", "Helvetica", sans-serif;

Comparing it to old Unbranded, it seems to load application.css after unbranded.css. The old version doesnt load application.css at all

Why

This is a bug compared to v12

Who needs to work on this

  • developers

Who needs to review this

  • developers

Done when

  • [ ] Unbranded pages dont use Transport font

joelanman avatar Oct 07 '22 15:10 joelanman

another option would be to remove the unbranded template until we know how we want to approach it

UPDATE

actually we need it for the Password page, which needs to be unbranded

joelanman avatar Oct 07 '22 15:10 joelanman

The reason this is happening is because we've folded application.css into the extensions system [1]; the default page head does not include application.css directly [2, 3].

Undoing this specific change would fix restore the behaviour of the unbranded template from before, although I would need to understand whether @nataliecarey made this change for any reason beyond just simplifying the code.

lfdebrux avatar Oct 10 '22 10:10 lfdebrux

We've agreed to back out the changes adding application.css to the extensions system to fix this for now, I'll raise a PR for that now. But we'd like to revisit how prototypes that don't want to use GOV.UK Frontend work in future, @joelanman to write a ticket for that.

lfdebrux avatar Oct 21 '22 09:10 lfdebrux