Alexey Knyazev

Results 137 comments of Alexey Knyazev

- [x] `NewActiveCornerReached` refers to undefined `split_active_corners`.

- [x] `NewActiveCornerReached` sets unused `topology_edge_list` values.

- [x] What buffer should `ParseEdgebreakerStandardSymbol` use? Is `bit_symbol_buffer` somehow related to `eb_symbol_buffer`?

- [ ] `MapCornerToVertex` assigns to uninitialized `corner_to_vertex_map_[0]`.

- [x] Section 2.3 should mention `.empty()` from `std::vector`. It's used by `EdgeBreakerTraverser_ProcessCorner`, `EdgeBreakerAttributeTraverser_ProcessCorner`, and `PopNextCornerToTraverse`.

- [x] `first_vert_id` is used as function in `RecomputeVerticesInternal`.

- [x] Is `static_cast` in `ConvertSymbolToSignedInt` needed to be in the spec?

- [x] `DecodeTaggedSymbols` still refers to uninitialized `l_rans_base`.

- [x] `IsTopologySplit` uses pointer syntax (`*`) for writing out `out_face_edge` and `out_encoder_split_symbol_id`; `MeshPredictionSchemeTexCoordsPortablePredictor_ComputePredictedValue` uses pointer syntax for writing out `predicted_value_`. Other functions don't use `*`. Is it intended?

- [x] `last_vert_added` in `NewActiveCornerReached` isn't initialized.