Alexey Knyazev
Alexey Knyazev
- [x] Extra dot: ![image](https://user-images.githubusercontent.com/3479527/31818946-5d02a9b6-b5ab-11e7-9a27-297ada0e83d6.png)
- [x] What does `.data()` mean in `DecodeAttributeSeams`, `DecodePredictionData_ConstrainedMulti`, `DecodePredictionData_TexCoords`, `DecodePredictionData_GeometricNormal`, and `MeshPredictionSchemeConstrainedMultiParallelogramDecoder_ComputeOriginalValues`?
- [x] Consider harmonizing array semantics in bitstream types: `UI8[size]` vs `size * UI8`.
- [x] `EdgebreakerValenceDecodeSymbol` and `ParseEdgebreakerStandardSymbol` don't have arguments, but they're used with `sym` in `EdgebreakerDecodeSymbol`.
- [x] `EdgebreakerValenceDecodeSymbol` refers to undefined `edge_breaker_symbol_to_topology_id` array.
- [x] `CornerToVert` accepts two arguments `(att_dec, corner_id)`, but all its usages in `NewActiveCornerReached` provide only one.
- [x] After https://github.com/google/draco/commit/308b812c2caf14a31cedf66dea3a468ee3469d61, `curr_att_dec` is being used in `NewActiveCornerReached` before its first initialization to `0` in `DecodeAttributeData`. Should connectivity decoder always use `0`? If so it could be a...
Small question regarding `f[n]`: > When bit reading is finished it will always pad the read to the current byte. - [x] When `f[n]` is being read in a loop,...
- [x] In `DecodeTaggedSymbols` before https://github.com/google/draco/pull/251/commits/cf02c772fe87992c45f5688ce82659a7918fa39b, `rans_precision` was equal to `4096` and `l_rans_base` to `16384`. After that commit, `rans_precision` became undefined and one of two occurrences of `l_rans_base` has been...
- [ ] `PosOpposite` and `SetPosOpposite` refer to undefined `opposite_corners_` array. What length should it have? Draco source suggests that `opposite_corners_` consists of int32 elements and its length is `num_faces...