Lewis Russell comments

Results 937 comments of


                                            Lewis Russell

feat(extmarks): expose spell from extmarks

Nice! What's the plan with navigation? As is, this only allows #19351 to be simplified.

feat(extmarks): expose spell from extmarks

For now I don't think options passed to `nvim_set_decoration_provider` should influence in any way how extmarks are rendered. Specifically any extmark with `spell=true` should always have spelling applied and not...

feat(folds): add 'foldoptions' option

Hmm, `foldlevelmarker` sounds like it's related to `foldmarker`. Maybe `foldcolumnlevel` or `foldcolumndigits` would be better?

feat(folds): add 'foldoptions' option

I'm not an expert in this area of the codebase but LGTM :+1:

feat(folds): add 'foldoptions' option

~@justinmk: I see your point, but I half-disagree. `foldcolumn` really just defines how much space the fold column occupies ...~ Just saw your edit whilst composing a response. 👍 to...

feat(lua): vim.ui_attach to get ui events from lua

I know the PR is still draft, but is there a reason this is done for lua only as opposed to the API?

feat(lua): vim.ui_attach to get ui events from lua

So does `nvim_set_decoration_provider`

feat(lua): vim.ui_attach to get ui events from lua

Messaged about it on matrix. Basically the decor stuff could (and maybe should) have been added to `vim.*` and going forward lua-only stuff should be kept outside of the API

feat(window/ui): add splitscroll option

Are you sure we would want this as default? Isn't the point of the scrolling to ensure the split doesn't cover the last position of the cursor?

feat(window/ui): add splitscroll option

Hmm, sounds like the current behaviour is naive/simple and now we just want to make it "smart". I'd contemplate not even making an option for this and just change the...