Lewis Russell
Lewis Russell
@lll9p are you able to assist at all?
Ok, thanks for having a look into it. Opening in a non git repo works on Mac/Linux (as it is tested via CI), so git is behaving differently on Windows....
This will be difficult to resolve without repro steps. I've looked into the Neovim source and this error mostly only happens when a `BufFilePre` autocmd runs, either if it changes...
This will require passing the `culhl` argument to `sign_define()` (or `cursorline_hl_group` for extmarks), and also require us to define cursorline variants for all the required sign highlights.
We can do something like this but note once `git add --patch` is run then the whole file will be marked with added signs again (except for the staged hunk),...
Stash hunks is easy enough but how would/can we handle unstashing. Also what exactly happens when a hunk is stashed. Do we create a new stash for each stashed hunk...
Without secondary signs, how do you expect this to work exactly? What would the implementation roughly do?
You can't apply highlights once the lines are applied. Highlights can only be configured as the extmark is set, similar to virtual text.
TIL about git smudging and cleaning. If smudge/clean commands all work via stdin/stdout, we could simply apply the filters before diffing? Would add quite a lot of complexity and probably...
Don't we just need to adapt the output of `git show ` and pass it through the filter which can then be compared to the working copy (the buffer contents)?