Richard Levitte

Results 452 comments of Richard Levitte

> @levitte there are some unresolved comments - please open the Files changed view and look at the unresolved comments. I believe I've addressed them all now

Rebased on top of fresh master. Shouldn't impact on reviews

Should I squash the fixup commits and push that (on top of same base)? The force-push link will show if anything changed.

Merged into master 1751334f59816d675a1ea85e98434a8231a58efe Refactor OpenSSL 'EdDSA' EVP_SIGNATURE to allow use with EVP_PKEY functions 66966827740a04249300b0b25735e9d4c9bcab26 Add ED25519 and ED448 support for EVP_PKEY_{sign,verify}_init_ex2() :

This mostly indicates that no one is using blowfish in a way where the OID is important. I'd suggest correcting it or removing it. Letting it continue to be wrong...

It's a bit surprising that the news reached up this late, especially considering that the strongswan issue odes refer to OpenSSL...

I've still to test ECDSA+hash, therefore this is still a draft. It shows where things are going, though...

This one is now done and ready for review. But please, #23416 first!

Rebased again on top of a fresher #23416 (resolved a merge conflict with master)