Richard Levitte

Results 452 comments of Richard Levitte

(also, it must be late at night, but I seem to get a different key ID for that public key than they do... so if someone else could verify that...

@dot-asm, I'm hoping on your meticulous review around how I worded things. You have a better grasp on the native vs hosted environments than I, and although I tried to...

Anyone else, feel free to review as well.

I don't understand the need for this function... Will it be useful for us? For any algorithm? (I'm thinking that if there are engines that implement new algos out there...

``` # 01e0:-22cb69bec0cf8d93 3d9c6fdd645e8505 91cca3d62c0cc000 # 01e0:+22cb69bec0cf8d93 3d9c6fdd645e8505 91cca3d62c0cdd61 # ^^^^ ``` This isn't just trailing bits, it's trailing *bytes*, and I don't quite understand why you'd have extra trailing...

Would you mind posting a link to the test vectors? For our purposes, I agree that you should either throw away the vectors that aren't multiple of 8 bits in...

If you want to be perfectly correct, `asc` should be changed to `8bit` rather than `latin1`, because it does the same (wrong) job on all 8bit character sets. Also, renaming...

An example of this catch 22 situation was identified in [PR#4840](https://github.com/openssl/openssl/pull/4840#pullrequestreview-80971300), which could easily be handled with this PR (all that's needed is a `predefined` function that computes the predefined...

Hmmm, the two Travis errors seem unrelated to this PR.

Rebased on fresher master, let's hope that satisfies Travis a bit better