Richard Levitte
Richard Levitte
That PDF refers to https://datatracker.ietf.org/doc/draft-irtf-cfrg-kangarootwelve/, which also describes the algo, *and provides test vectors*. Might I suggest adding some tests, based on those test vectors?
I could go with having this as an unstable feature, only to be enabled on demand... especially if libtomcrypt already have infrastructure for that sort of thing (er, I forget...
I suggest doing so as immediately as possible.
Nice cleanup. This PR could use some love, though...
I just had a look at #624, and it does appear to answer this issue.
I just had a quick look, and ran the test too, and this does appear to answer #622. I would merge this.
I've thought of this discrepancy in the last few weeks, but haven't had the peace of mind to figure out a solution. I'm not at all convinced that the *user*...
> > Even with various trial&error, I was unable to get rid of the following Windows build warning/error: > > @levitte, meanwhile found the culprit: > > ``` > 63f187cfedd...
I'm not in favor of factoring out this code. Granted, it's present in two sources, but `engine/e_loader_attic.c` is legacy and doomed to be irrelevant, so factoring out this bit of...
That being said, I'm still interested in what this actually still fixes. I see that you can argue readability, and I can see what you mean with that in a...