Roman Leventov

Currently rehash() first replaces table arrays and then re-fills them with elements. Collection has incosistent state for relatively long time. Rehash should first build new table and then quickly replace...

In implementation for Java 8 we can use `forEach` instead of plain old iteration.

https://github.com/code-review-checklists/java-concurrency#fjp-no-blocking

Extend fjp-instead-tpe item

1

https://twitter.com/leventov/status/1237688980805758976

In general, all methods listed here: https://github.com/apache/druid/issues/9285#issuecomment-593066477 should be noted in https://github.com/code-review-checklists/java-concurrency#check-await

https://www.nurkiewicz.com/2014/11/executorservice-10-tips-and-tricks.html

http://www.javapractices.com/home/HomeAction.do, "Threads" section

Incorporate this into one of existing items, or create a new item.

https://github.com/google/error-prone

Use read-write lock in Hierarchy

9

Please use read-write lock, such as `std::shared_mutex`, here: https://github.com/log4cplus/log4cplus/blob/936213586d3f5190f803e76da606a54ae3120c89/include/log4cplus/hierarchy.h#L299 It guards mostly read-only operations, yet using an ordinary mutex induces noticeable contention.