Romain Leroux

Results 57 comments of Romain Leroux

>This is more abstract/handy, as otherwise one has to keep track of more state in one's application. As you have to keep track of some state like the connector and...

Hi, I'd gladly accept a PR to update those !

Thanks it looks good. However I think the `if` are getting a bit too nested, could you refactor it with a `cond` and `and` conditions ?

Thanks for pointing out this tricky issue, I released `0.4.2` with the locking fix, let me know how it goes.

It's a possibility indeed, but it's a lot of refactoring. If everything is fine, I'd accept such a PR though.

@vincentjames501 do you still observe the thread safety issue after the require locking fix ?

Hi, thank you for your investigations. I released version `v0.3.4` with `PING` and `ECHO` support. However as you said I am not sure it is necessary to implement all the...

In [this](https://github.com/tantivy-search/tantivy/issues/563#issuecomment-805177242) comment @maufl suggested an alternative specialization based implementation to address the `A::State` type issue. I can update this PR with it if needed.

Could this be solved by leveraging `StreamWithState` from `fst` crate which is now available (details in [this commit](https://github.com/BurntSushi/fst/commit/fc757c65467d8033019de37c990b302bfbf43276)) ?

If my understanding is correct, here are the things to do: - Add a `search_with_state` method to `tantivy_fst::Map` like [fst::Map::search_with_state](https://docs.rs/fst/0.4.5/fst/struct.Map.html#method.search_with_state) in `fst`. - Add a `TermWithStateStreamerBuilder` (similar to [TermStreamerBuilder](https://docs.rs/tantivy/0.14.0/src/tantivy/termdict/fst_termdict/streamer.rs.html#13-73)) to...