celtuce icon indicating copy to clipboard operation
celtuce copied to clipboard

Deprecations

Open vemv opened this issue 2 years ago • 2 comments

Hi,

great library 🙌

I noticed that it uses a number of deprecated Java methods. For example lein eastwood reports 30+ deprecations in the lettuce-core module.

Here's a brief sampler:

src/celtuce/impl/cluster.clj:394:15: deprecations: Instance method 'public abstract java.util.List io.lettuce.core.api.sync.RedisSortedSetCommands.zrangebylex(java.lang.Object,java.lang.String,java.lang.String)' is deprecated.
src/celtuce/impl/cluster.clj:396:15: deprecations: Instance method 'public abstract java.util.List io.lettuce.core.api.sync.RedisSortedSetCommands.zrangebylex(java.lang.Object,java.lang.String,java.lang.String,long,long)' is deprecated.
src/celtuce/impl/cluster.clj:314:5: deprecations: Instance method 'public abstract java.lang.Long io.lettuce.core.api.sync.RedisSortedSetCommands.zcount(java.lang.Object,double,double)' is deprecated.

It seems a good idea to eventually fix them so that one can continue to upgrade Lettuce (which can always be needed for various reasons) seamlessly.

Cheers - V

vemv avatar Aug 06 '21 22:08 vemv

Hi, I'd gladly accept a PR to update those !

lerouxrgd avatar Aug 07 '21 16:08 lerouxrgd

Fair enough, it might not be that difficult since every deprecation note tells you what to use instead

Might give it a shot

vemv avatar Aug 07 '21 23:08 vemv