LeoTM
LeoTM
> I think there is a risk under maintenance that we add a new syntactic async generator in the SES-shim, that would be unexpectedly transformed under Hermes. > > Let's...
> @leotm Can you make sure that we only lint _once_? Currently, we're running the lint workflow on multiple versions of Node.js, which wastes cycles nb (thx @kriskowal beat me...
draft pending testing changes from endo sync in VM and React Native
we considered implementing https://github.com/endojs/endo/blob/a13a879a8ea647d3e13bc6cb223de1b413e06632/packages/ses/src/intrinsics.js#L103-L110 instead in ```js // packages/ses/src/tame-function-tostring.js // ... if ( !/^[A-Z]/.test(func.name) && func.prototype !== undefined ) { func.prototype = undefined; } // ... ``` but at this...
https://github.com/endojs/endo/actions/runs/11366289654/job/31616329403?pr=2563 ```console Run npx playwright install --with-deps npx playwright install --with-deps shell: /usr/bin/bash -e {0} Installing dependencies... Switching to root user to install dependencies... Hit:1 http://azure.archive.ubuntu.com/ubuntu noble InRelease Get:[2](https://github.com/endojs/endo/actions/runs/11366289654/job/31616329403?pr=2563#step:9:2) http://azure.archive.ubuntu.com/ubuntu...
> Another thought: concise functions in Hermes may incorrectly have a `prototype` property, but bound functions do not: > > ``` > $ eshost -se '[()=>{}, (()=>{}).bind()].map(fn => Object.hasOwnProperty.call(fn, "prototype"))'...
> LGTM module suggestions, especially [#2563 (comment)](https://github.com/endojs/endo/pull/2563#discussion_r1807040061) > If all this is true, then it makes sense to permit prototype: undefined on these three. So I'll approve on that basis....
> Now that #2624 is merged, I'm changing to "Request changes". > > Does #2624 indeed enable this to be simplified? What does it simplify down to? after testing https://github.com/endojs/endo/pull/2624...
Passing Smoke E2E: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/606d9216-a472-4e4f-92ce-b08ada66743b
Failing Regression E2E: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6b1a7d83-e953-4d96-b15d-a21366ccdbbf - iOS: 6/14 - Android: 8/14 NB: passed on `main` May 27 https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4697868f-2919-4d5d-b643-a6a34cb7d3bc so currently expected