endo icon indicating copy to clipboard operation
endo copied to clipboard

Create GitHub composite action for CI workflow

Open leotm opened this issue 1 year ago • 2 comments

What is the Problem Being Solved?

Clean up CI tech debt to avoiding duplication, finishing what we started 4y ago

  • https://github.com/endojs/endo/pull/37

https://github.com/endojs/endo/blob/df5a0e8677432afc12255bfcb67903045d1597c1/.github/workflows/ci.yml#L11-L14

so replace all our begin/end macro comments with a GH composite action

spotted earlier by @boneskull

Description of the Design

e.g. uses: endojs/[email protected] (or mvp via filepath)

the alternative is a reusable workflow

Security Considerations

Scaling Considerations

this improves scaling CI jobs

Test Plan

Testing out your action in a workflow

local testing works well with nektos/act

Compatibility Considerations

consider: linux / windows / macOS

Upgrade Considerations

upgrading this composite actions to e.g. uses: endojs/[email protected] involves pushing a new tag (unless using commit sha)

leotm avatar Sep 17 '24 11:09 leotm

@leotm Can you make sure that we only lint once? Currently, we're running the lint workflow on multiple versions of Node.js, which wastes cycles

boneskull avatar Sep 20 '24 19:09 boneskull

@leotm Can you make sure that we only lint once? Currently, we're running the lint workflow on multiple versions of Node.js, which wastes cycles

nb (thx @kriskowal beat me to it)

  • issue: https://github.com/endojs/endo/issues/2283
  • fix: https://github.com/endojs/endo/pull/2477

leotm avatar Oct 03 '24 18:10 leotm