metamask-mobile
metamask-mobile copied to clipboard
feat: @lavamoat/react-native-lockdown
Description
Introduce Hardened JavaScript now on both iOS (RN JSC) and Android (Hermes) via Metro (@lavamoat/react-native-lockdown beta) instead of RN patch
TODO
- [x] Remove stale SES shim (now via @lavamoat/react-native-lockdown)
- [x] Remove stale RN iOS patch
- [x] Add temp @lavamoat/react-native-lockdown .tar.gz
- [x] Add temp SES patch https://github.com/endojs/endo/pull/2855
- [ ] Replace temp .tar.gz and SES patch with official @lavamoat/react-native-lockdown once https://github.com/LavaMoat/LavaMoat/pull/1716 merged
- [ ] Remove experimental feature toggle UI
- [ ] Fix smoke/regression e2e test timeouts
- https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2b384037-b417-4259-b263-ad6ce3c35a41
- nightly regression tests currently failing on
main, once passing check those on this branch
Related issues
Fixes:
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.