leoslr

Results 5 comments of leoslr

@olivier7delf it should not happen very often, but it most likely will at some point, and when that happens there will most likely be issues. Even if we redeploy a...

@KolevDarko The command `yarn hardhat deploy-contracts-through-deployer` deploys the contracts from the list. However we did not want to put all contract in there for now (only the new and recently...

> Code is great! I'm just missing some context: > > * What is this PN adding that [any-to-eth-proxy](https://github.com/RequestNetwork/requestNetwork/blob/master/packages/advanced-logic/specs/payment-network-any-to-eth-proxy-0.1.0.md) does not support, apart from the fact that this is not...

@yomarion I've made an update based on Alex comments that checks that `network` is define within the `throwIfInvalidNetwork` function. It makes this test fail https://github.com/RequestNetwork/requestNetwork/blob/master/packages/advanced-logic/test/extensions/payment-network/native-token.test.ts#L177 Are there any reason behind...

> > @yomarion I've made an update based on Alex comments that checks that `network` is define within the `throwIfInvalidNetwork` function. It makes this test fail https://github.com/RequestNetwork/requestNetwork/blob/master/packages/advanced-logic/test/extensions/payment-network/native-token.test.ts#L177 Are there any...