requestNetwork
requestNetwork copied to clipboard
fix: escrow ci deployment
Description of the changes
Was trying to add the Escrow contract to the request-contracts Docker image. First I created new escrow deployment script that uses the old way for deployment in scripts/deploy-payments.ts Then it turned out that test-deploy-all should be used, in there I made another fix, removed the hardcoded Erc20FeeProxy and I'm getting it as an argument.
Coverage remained the same at 88.287% when pulling 1e3c4c2d3356259126c29707f695afa0cd515e76 on feat/escrow-ci-deployment into f450b5916c0f277f25e01210c4db60783d7f3225 on master.
@leoslr Maybe we need to write a completely new script that will use deployWithCreate2FromList to deploy all contracts then ?
@KolevDarko The command yarn hardhat deploy-contracts-through-deployer
deploys the contracts from the list. However we did not want to put all contract in there for now (only the new and recently modified ones). The older contracts keep being deployed using the deploy-payments script so we deploy them at the same address as before