Leonardo Losoviz

Results 55 comments of Leonardo Losoviz

Please notice that if you pass a variables dictionary including the variable `date` it doesn't throw an exception. It only does when variable `date` is not present in the dictionary...

Currently it fails with a better error when either the variable is defined in the operation name but not in the variables, or the other way around. Only when both...

This problem can be fixed by checking in `Execution/Request.php`, function `__construct`, that the variable that produces the exception is not `null`. Currently: ```php $variable = $ref->getVariable(); if ($variable->hasDefaultValue()) { ```...

Ops, I closed by mistake. This branch in my fork handles this solution a bit better: https://github.com/getpop/graphql-parser/tree/fix-exception-when-no-args-declared

My solution is simple, because it notices that, if the variable was not defined in the operation, then this line will return `null`: ```php $variable = $ref->getVariable(); ``` Maybe this...

That would be wonderful! How to kick-start this development? Should I try to do it? Or anyone else can take care of it? (I'm not experienced with Youshido's codebase, just...

To clarify: this bug also happens if no operation type directives were defined in the query; in that case, the overriding `$directives` is an empty array

Ops, I closed by mistake. This branch in my fork deals with this issue: https://github.com/getpop/graphql-parser/tree/fix-overriding-directives

Alright. I just added a test, will submit the PR now.