Daniel Lemire
Daniel Lemire
So only the performance check is failing, which is what you'd expect.
> so we can merge? Yes. I will merge. However, I want to do manual tests. The perf check that we do in unit testing is rough. I will not...
The PR is approved. I just want to do manual checks before the final merge.
I did not forget.
@michaeleisel Would you comment?
Of course, the relevance of the current pull request is in question if your goal is to parse numbers that do not fit 64-bit number types (`uint64_t`, `int64_t` or `double`/`float64`)....
It would be important to define the goals. If what you want is to provide your own number parser, that could possibly be done, through a template of some kind.
It is not a mistake that we refuse to parse the large integers, it is by design. I don't think we want to change this behaviour. Now, providing the ability...
@spnda Have a look at the failing tests, please.
> Should the IF_CONSTEXPR be moved into another header? Macros need to prefixed, e.g., `SIMDJSON_IF_CONSTEXPR`.