Daniel Lemire
Daniel Lemire
@shshen Yes. That's reasonable. Do you want to prepare a pull request ?
> Could i change BufferReverseIntIteratorFlyweight's parent to PeekableIntIterator if you do not mind? It does not provide the PeekableIntIterator interface, but if you are willing to code the missing `int...
@anacrolix > The p return value from Bitmap.FromUnsafeBytes is incorrect Please provide evidence. A simple example would suffice. I strongly discourage such vague statements. > untested I have added a...
Thanks. I am certainly inviting contributions and feature requests but we cannot burden the main implementation with an additional data structure that most users will benefit from. We could add...
@stephenberry pull request invited!
The library is C++11 and we do not want to change this. Using macros is acceptable.
You are accessing the bitmap from multiple threads without synchronization. This is explicitly unsafe, please see our README.md file: https://github.com/RoaringBitmap/RoaringBitmap?tab=readme-ov-file#thread-safety In the case of `Roaring64NavigableMap`, the `isEmpty()` is a mutator...
> we do hope that Roaring64NavigableMap is thread-safe during multithreaded reads Currently, the isEmpty function calls the function computing the cardinality. This function, in turn, triggers a condition and caches...
> Would having it in the header here be much different from roaring.h (with warning comments of only accessing value)? Can you be specific? There is no `roaring_iterator_t` or `roaring_iterator_s`,...
@nardyy01 Thanks. This is much clearer. @SLieve What do you think? I submit to you that we are probably unlikely to change this struct in the future.