Daniel Lemire
Daniel Lemire
@pauldreik I do not have a specific example in mind. That's why I wrote that you *may* have been optimistic. But, as a rule, I am sure you will agree...
Thanks for the report.
At a glance, your code looks fine... If the input string is valid UTF-16, then it should work. However, the inputs appear to be invalid. E.g., `\udc08\udc08` is not a...
@erikcorry > The new utf8_length_from_utf16_with_replacement would produce the same result as the old function for all valid utf-16 inputs. The change would only be on invalid inputs. This makes me...
@erikcorry Further, because `utf8_length_from_utf16_with_replacement` needs to validate the input anyhow, it could return a Boolean indicating whether the input needs replacement.
Sure, pull request invited.
@gaissmai Yes, although that would have to be a major release and we should carefully document that the constructor may panic. Pull request invited.
@lukesandberg > Just a random note. I wanted to use the Len() function to recover the value i passed to New instead of passing it around separately. But this issue...
@gaissmai Let me be clear: I am not at all dismissing the issue you raised. If people want to close the issue, we will close it... But, meanwhile, I am...
@gaissmai Sure!