fast_float icon indicating copy to clipboard operation
fast_float copied to clipboard
verified publisher icon fastfloat

Build warning on Clang with -Wdeprecated-redundant-constexpr-static-def

Open stephenberry opened this issue 1 year ago • 3 comments

out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated

Enabling -Wdeprecated-redundant-constexpr-static-def with warnings as errors causes fast_float to not build on Clang.

Fixing this should make the code cleaner as well.

stephenberry avatar Jul 22 '24 13:07 stephenberry

@stephenberry pull request invited!

lemire avatar Jul 22 '24 17:07 lemire

I think to support C++11 you would need macros around the old expressions. Do you want this?

stephenberry avatar Jul 23 '24 19:07 stephenberry

The library is C++11 and we do not want to change this.

Using macros is acceptable.

lemire avatar Jul 23 '24 20:07 lemire

I can't reproduce this issue anymore, any more details on versions used @stephenberry?

dalle avatar Nov 23 '24 09:11 dalle

This issue was reported for version 6.1.3, perhaps someone fixed it. Are you making sure to build with C++17 or later?

stephenberry avatar Nov 23 '24 14:11 stephenberry

This was fixed in #268 for release 6.1.5.

dalle avatar Nov 23 '24 14:11 dalle

Thank you for your report, I'm closing this issue.

dalle avatar Nov 23 '24 15:11 dalle