Daniel Lemire
Daniel Lemire
I built this PR while passing `-mavx2` to the compiler. Note that, right now, this optimization won't build otherwise (__AVX2__ is a compile time flag that is not defined by...
Looks like a good catch.
@DanielThomas Could you also do: https://github.com/RoaringBitmap/RoaringBitmap/blob/dda04be1c1ff514b94875499476825daba4ed3dc/RoaringBitmap/src/main/java/org/roaringbitmap/buffer/MappeableBitmapContainer.java#L55
@DanielThomas Can you check the CI logs? I see... ``` symbol: variable MAX_CAPACITY location: class MappeableBitmapContainer /home/runner/work/RoaringBitmap/RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/buffer/BufferBitSetUtil.java:24: error: cannot find symbol static final private int BLOCK_LENGTH = MappeableBitmapContainer.MAX_CAPACITY / Long.SIZE;...
@DanielThomas This PR still does not build... ``` /home/runner/work/RoaringBitmap/RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/Roaring64NavigableMap.java:1165: warning: [deprecation] MutableRoaringBitmapPrivate in org.roaringbitmap.buffer has been deprecated MutableRoaringBitmapPrivate.repairAfterLazy((MutableRoaringBitmap) lowBitmap); ^ /home/runner/work/RoaringBitmap/RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/buffer/ImmutableRoaringArray.java:185: error: cannot find symbol bitmapArray.limit(MappeableBitmapContainer.MAX_CAPACITY / 64); ^ symbol:...
> Based on your comments on the other PR about code duplication being a thing for the project, I've rolled back any other changes and restricted this to making the...
Extended, see https://github.com/RoaringBitmap/RoaringBitmap/pull/726
@DanielThomas You have credit in PR https://github.com/RoaringBitmap/RoaringBitmap/pull/726 where I extended this work.
I think it would be an acceptable breaking change.
Emscripten is currently not supported. Pull requests and further documentation invited.