Daniel Lemire
Daniel Lemire
@bricss Are you available to help push this forward?
@bricss Lack of knowledge of C++ could be a problem.
> since it seems that currently percent decoding is only performed while parsing the host. Ah ! Ah ! This was so before `url_search_params`, but now we do have this...
@jeffplaisance and @anonrig : I think we need a new benchmark where we could make this code shine. What sort of applications tend to generate long URLs with longer percent...
@jeffplaisance That's helpful. I'll work on a benchmark "soon". **Update**: Done by https://github.com/ada-url/ada/pull/477
We have a precursor PR: https://github.com/ada-url/ada/pull/478
@CarlosEduR What do you run in your computer? Windows, macOS, Linux?
@CarlosEduR Ok. So the first step is 'just' to add can_parse to our benchmarks: https://github.com/ada-url/ada/blob/ccb7a2646f53a2aa9c65f3ec644f856d57d2b341/benchmarks/benchmark_template.cpp#L21 Basically copying this code, and replacing 'parse' by 'can_parse' ought to do. This would be...
@CarlosEduR Would you issue a PR? This is fantastic!!! Once we have good metrics, we can more easily test out ideas. It seems that there are obvious things that we...
Yes. Absolutely. Right now I don't know the easiest way to go forward.