Daniel Lemire

What I see are reports about an issue in old code contributed by @addaleax It seems unclear to me (though not impossible) there there is a defect in this code....

Something does not add up. The trace has... ``` node::options_parser::OptionsParser::AddAlias(char const*, char const*) /home/runner/work/node/node/out/../src/node_options-inl.h:106 ``` But `AddAlias(char const*, char const*)` is not on line 106, rather it appears on line...

Let us try to rerun the tests.

> it's possible that the debug output is a red herring. Right. So we are being mislead as to where the issue is actually happening?

@anonrig I did not investigate deeply. Running tests locally under Windows. I see two 'simple' test failures. 1. This one: ``` === release test-permission-fs-read === Path: parallel/test-permission-fs-read AssertionError [ERR_ASSERTION]: Expected...

Ok. I have spent some time on the issue but with little progress, unfortunately. But my instinct is telling me that this PR is essentially correct and that the failures...

The strict equality in the cwd test was introduced by @wzoom

> We can question what the tests are doing, but path is a very sensitive module (especially security-wise) so I'm actually glad that they caught what could be regressions introduced...

This is the C:\\WINDOWS failing test: https://github.com/nodejs/node/blob/fc029181df676f97b9e329639760f87722cbcece/test/parallel/test-child-process-cwd.js#L4

What the [test-child-process-cwd.js](https://github.com/nodejs/node/blob/fc029181df676f97b9e329639760f87722cbcece/test/parallel/test-child-process-cwd.js#L4) test does is to call this in a spawned process... ``` const pwdCommand = isWindows ? ['cmd.exe', ['/d', '/c', 'cd']] : ['pwd', []]; ``` It passes `process.env.windir`...