Thomas Portelange

Results 153 comments of Thomas Portelange

a minor improvement is to add this in the init method ```php public function init() { parent::init(); // Optimize search form if (strpos($this->getRequest()->getURL(), 'schema/SearchForm') !== false) { session_write_close(); } }...

So currently I have this which is not too bad, although it would be a lot cleaner to be handled directly by the component. > $('.uploadfield-item__thumbnail').entwine({ > onclick: function() {...

@mlewis-everley :-D that should be the default behaviour shipped by the framework

or add an extension point that would work for me as well (would even be better actually)

as a side note, injecting a custom instance of AssetAdmin like this ```yml SilverStripe\Core\Injector\Injector: SilverStripe\AssetAdmin\Controller\AssetAdmin: class: LeKoala\Base\Admin\BaseAssetAdmin ``` Fails as well as it gives this js error bundle.js?m=1624034376:1 Uncaught TypeError:...

In the meantime, this can be fixed by replacing the UploadField instance and adjust the `getEncodedItems` but still i'm a bit sad to discover this issue after upgrading to the...

@michalkleiner sure ! but it's not what is used by the UploadField by default. https://github.com/silverstripe/silverstripe-asset-admin/blob/96b13878164ba6e25f449df7eb04f1aa61dea3f4/code/Forms/UploadField.php#L215 so i have to replace the uploadfield instance with a custom one that use getObjectFromData....

do you have an example with the issue? options in optgroup should work fine

@DrFlowil good catch there, that's something i overlooked when implementing optgroups should be fixed here https://github.com/lekoala/bootstrap5-tags/releases/tag/1.6.16

yes the idea is to have standalone, autonomous components. currently since it's easier to maintain i have everything under one repo. it has no stable release yet because i'm still...