Thomas Portelange

Results 153 comments of Thomas Portelange

I agree with @esrauchg now that I think more about it. The issue I had was that https://github.com/protocolbuffers/protobuf/blob/1a58e5df6aced9eb49c67e761ced9d36efc81867/php/src/Google/Protobuf/Internal/Message.php#L1872 was somehow calling strlen on getJsonName but that was returning null and...

from what i see in the tests, it's not my changes that creates error but i've compiled the files on windows, it requires this to work module.exports.rules['linebreak-style'] = ['error', 'windows'];...

hi @GuySartorelli it does not seem related to my PR itself first, FileField don't need the ID suffix https://github.com/silverstripe/silverstripe-framework/blob/b662f03b75a7f1e14075f3068a5c787197724501/src/Forms/FileField.php#L142-L143 from what i can see, the upload part itself works fine...

hey @GuySartorelli here you go https://github.com/silverstripe/silverstripe-admin/pull/1854 seems to work fine on my end! i targeted 5.3 i don't think anyone expected this to work anyway, but this could also be...

@owaisahmed5300 you can give a try to https://github.com/lekoala/bootstrap5-tags :-)

to add a bit more info i've also tried using wsl, but then it gets even weirder it skips the index page and only serves subdirectories. `**/*.html` should keep folders,...

oh ok good catch i didn't know where to look. if I understand the path.relative function may return backslashes on windows. i've made a PR the wsl issue is on...

using an empty placeholder (placeholder="") should work too... the idea is that you generally want some kind of placeholder. in many selects, the first option is the one that acts...

should be fixed https://github.com/lekoala/bootstrap5-tags/releases/tag/1.7.16