Martin Trobäck

Results 55 comments of Martin Trobäck

That seems like it could potentially work. I'll look in to that. Thanks. :+1:

I'll see what I can do. :)

Yeah, no. I wouldn't know how to write a test for that function because I can't seem to follow when it's actually called. Would have been good to add all...

It's really not that hard to implement yourself. ```javascript const links = [httpLink] if (process.env.NODE_ENV === 'development') { links.unshift(apolloLogger) } ApolloLink.from(links) ``` Or wrap in a localStorage check so you...

Hmm, apparently the asterix might not be a standard. So perhaps we've done something wrong instead.

It seems to be working. But we have a couple or props we need to add. `duration`, `startTime` and maybe `className`.

Can also confirm that something is fishy. Clean CRA install with luxon, styled-components and media-stream-library. `yarn start` ``` Failed to compile. ./node_modules/media-stream-library/dist/media-stream-library.min.js 7851:38 Module parse failed: Unexpected token (7851:38) File...

Feel free to do a PR and we'll take a look at it.

Not sure about displaying it in the stats box, but adding debug logging for MSP shouldn't too much of a problem. What kind of information are you interested in?

If I can use the VideoPlayer context I've created in #89, this hook would be even easier to make.