Kunal Mehta
Kunal Mehta
This is an upstream issue with dh-virtualenv: https://github.com/spotify/dh-virtualenv/issues/326 and one of the reasons I've proposed dropping it altogether: https://github.com/freedomofpress/securedrop/issues/6538.
Now that we've dropped dh-virtualenv, bumping to 12 should be doable.
Yep! We also have https://github.com/freedomofpress/securedrop/issues/6447#issuecomment-1416414830 which is the even-longer term solution of embedding the key directly in the `sources.list.d` file, which we can do in bookworm. But I suspect we'll...
For prioritization purposes, is there any place we currently use or expect duplicate headers? reqwest also has a HeaderMap type for this reason (see https://docs.rs/reqwest/latest/reqwest/header/struct.HeaderMap.html#method.get_all), we would need to change...
I'm boldly closing this as "not worth it" in today's CI setup. It is slow, but it's not the slowest job (usually piuparts) and I don't think CI speed is...
kushaldas [wrote](https://github.com/freedomofpress/securedrop-sdk/pull/149#issuecomment-740728352): > After digging more into the usage of [pydantic](https://pydantic-docs.helpmanual.io/), my personal preference would be not to use it. Major reason is in two parts: > > * We...
rmol [wrote](https://github.com/freedomofpress/securedrop-sdk/pull/149#issuecomment-741201272): > I'm coming to the same conclusion as Kushal, I'm afraid. > > It looks like it might be difficult to integrate `pydantic` with other class-based validation like...
nabla-c0d3 [wrote](https://github.com/freedomofpress/securedrop-sdk/pull/149#issuecomment-741555402): > This will be my last post on this PR/issue as this was just a proposal, but here is another example from the SDK code. > > 1....
rmol [wrote](https://github.com/freedomofpress/securedrop-sdk/pull/149#issuecomment-741876648): > > This will be my last post on this PR/issue as this was just a proposal, but here is another example from the SDK code. > >...
nabla-c0d3 [wrote](https://github.com/freedomofpress/securedrop-sdk/pull/149#issuecomment-743692529): > Our go-to web stack at work has evolved throughout the years and is now falcon + pydantic + sqlalchemy. Unfortunately, none of this code is public. The...