Kunal Mehta

Results 373 comments of Kunal Mehta

I tested this and it all works fine on 1.0.0rc2. I tried a [still webp image](https://upload.wikimedia.org/wikipedia/commons/d/d2/Capitalization_of_the_Internet.webp), and an [animated webp image](https://upload.wikimedia.org/wikipedia/commons/c/c8/Google_Android.webp), both rendered just like how Firefox does. I will...

> I will put it on the agenda for tomorrow's meeting just to make sure there are no unresolved security issues here, but as it stands, webp should be supported...

> It should be descriptive and uncontroversial, except that we couldn't account for: > > 1. `securedrop-log`, which nothing in either `securedrop-client` or `securedrop-workstation` appears to invoke; or > 2....

Also: this is great, will make it very easy to visualize the proposed changes in https://github.com/freedomofpress/securedrop-client/issues/1719 once we get there :)

(gonna land this, we can always make follow-up changes if it's not accurate)

I accidentally squashed the README commits when migrating and then dropped the CircleCI config since we need to redo it for GHA anyways.

The securedrop-workstation side of this is ready now and should land first: https://github.com/freedomofpress/securedrop-workstation/pull/1005

I just pushed "WIP: Have the sdk always shell out to the proxy" which is somewhat working, I messed up in negating a boolean somewhere so file downloading is a...

A bit of an update and what's left: * [x] @cfm and I discussed that we're good with outputting headers on stderr in streaming mode, except that it should be...

Oh also, it might be worth looking at the SDK error handling a bit closer, there's a few raised errors that I left with "FIXME", but also I saw at...