Kunal Mehta
Kunal Mehta
1. Here's my async commit, it's fine: https://github.com/freedomofpress/securedrop-proxy/commit/799f498796ab1a7cfdcaa2ce9b30a58ace9a2577 2. And then here's the I/O wrapper and I kind of hate it: https://github.com/freedomofpress/securedrop-proxy/commit/50e1b877b616246f47149454a99ef550d23e4d96 We can use fixtures to mock some of...
I'm quite happy with the integration tests I implemented today: https://github.com/freedomofpress/securedrop-proxy/commit/10c80ac1489310203bd004f62cb6ab450c9e1560 - they shell out to a binary and run against an HTTP server that is basically the same as...
We missed something when implementing streaming mode, specifically that we want to look at the response headers to verify download integrity via the `etag` header; I think this is reasonable....
For upstream tooling we can reuse: * piuparts: #1844, which is less useful in a container than I expected. * lintian, which spotted a number of things. Going to set...
One of the things I want to explore is running the tests against the installed Debian package. Because we use a virtualenv, this actually makes it straightforward to install the...
* cross-linking https://github.com/freedomofpress/securedrop-client/issues/1874 as a regression that we should be able to prevent with appropriate tests
I think if we remove the `update-desktop-database` and `update-mime-database` calls it should all just work. So we just need to test it.
We're currently stalled on applying most dependabot updates because the new semgrep version requires a new major version of urllib3, which it bumps despite it also being a prod dependency....
> * what I really want is https://github.com/dependabot/dependabot-core/issues/1595 in which the same package is upgraded in lock-step across all the components. This is now available so I've opened #2018. We've...
I somewhat started on this in https://github.com/freedomofpress/securedrop-client/pull/1895/commits/4853d4bc949cf77718b92d2399eed969ff7e6fd6, it's easiest if we commit the Qubes repo signing key (I pulled it out of a VM) and then add the sources.list file....